paleolimbot commented on code in PR #1009:
URL: https://github.com/apache/arrow-nanoarrow/pull/1009#discussion_r4594235861
##########
python/src/nanoarrow/_buffer.pyx:
##########
@@ -351,7 +351,9 @@ cdef class CBufferView:
return iter(memoryview(self)[offset:(offset + length)])
def _iter_struct(self, int64_t offset, int64_t length):
- for value in iter_unpack(self.format, self):
+ view = memoryview(self).cast("B")
+ view = view[offset * self.itemsize:(offset + length) * self.itemsize]
Review Comment:
I think we can just do this?
```suggestion
view = memoryview(self)[offset:(offset + length)]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]