raulcd commented on code in PR #55299:
URL: https://github.com/apache/arrow/pull/55299#discussion_r4598515541
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -964,9 +954,61 @@ if(ARROW_FILESYSTEM)
filesystem/util_internal.cc)
if(ARROW_AZURE)
- list(APPEND ARROW_FILESYSTEM_SRCS filesystem/azurefs.cc)
- set_source_files_properties(filesystem/azurefs.cc
+ set(ARROW_AZURE_STATIC_INSTALL_INTERFACE_LIBS Arrow::arrow_static)
+ if(Azure_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_AZURE_STATIC_INSTALL_INTERFACE_LIBS
${AZURE_SDK_LINK_LIBRARIES})
+ elseif(Azure_SOURCE STREQUAL "BUNDLED")
+ if(NOT WIN32)
+ list(APPEND ARROW_AZURE_STATIC_INSTALL_INTERFACE_LIBS CURL::libcurl
+ LibXml2::LibXml2)
+ endif()
+ endif()
+ set(ARROW_AZURE_LIB_SRCS filesystem/azurefs_module.cc
filesystem/azurefs.cc)
+ set_source_files_properties(filesystem/azurefs_module.cc
filesystem/azurefs.cc
PROPERTIES SKIP_UNITY_BUILD_INCLUSION ON)
+ # If libarrow_azure.a is only built, "pkg-config --cflags --libs
+ # arrow-azure" outputs build flags for static linking not shared
+ # linking. ARROW_AZURE_PC_* except ARROW_AZURE_PC_*_PRIVATE are for the
+ # static linking case.
+ if(NOT ARROW_BUILD_SHARED AND ARROW_BUILD_STATIC)
+ string(APPEND ARROW_AZURE_PC_CFLAGS "${ARROW_AZURE_PC_CFLAGS_PRIVATE}")
Review Comment:
oops, I missed adding the PC flags. I've updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]