krtab opened a new pull request, #12304:
URL: https://github.com/apache/arrow-rs/pull/12304

   # Which issue does this PR close?
   
   None, these are small cleanups in `parquet_derive`.
   
   # Rationale for this change
   
   A handful of small fixes noticed while reading the `parquet_derive` code.
   
   # What changes are included in this PR?
   
   - Fix a typo in `ParquetRecordReader`'s doc ("writing code" → "reading 
code").
   - Wrap the example structs in the `*_snippet` docs in `ignore` code blocks 
so they render with syntax highlighting, and drop the stray backticks around 
`Option<bool>`.
   - Build `name_to_index` in the derived reader with `collect` instead of a 
manual insert loop (slightly more optimal, directly allocates to the right 
size).
   - Reserve space for `num_records` in the derived reader before pushing 
records.
   
   # Are these changes tested?
   
   Covered by the existing `parquet_derive` and `parquet_derive_test` tests; no 
behavior change besides the up-front allocations.
   
   # Are there any significant user-facing changes?
   
   No.
   
   # AI usage disclosure
   
   This PR description was drafted with Claude Code. The changes were manual.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to