ViktorBystrov72 commented on issue #1591: URL: https://github.com/apache/arrow-go/issues/1591#issuecomment-6972528345
I reproduced the change on current main. The overflow fix in `6542b630` also updated the month and quarter test vectors to expect advancement on exact boundaries. The [current C++ code](https://github.com/apache/arrow/blob/21156bccc5f3b2eaaa21b9045cccd02ba332f435/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc#L982-L1009) advances the month, quarter, and year cases regardless of `ceil_is_strictly_greater`. Go v18.8.0 preserved exact boundaries with the default option. Which behavior should Arrow Go follow here? Restoring the older Go behavior would diverge from the C++ implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
