jbonofre commented on code in PR #1498:
URL: https://github.com/apache/arrow-java/pull/1498#discussion_r4611268652


##########
ci/scripts/build.sh:
##########


Review Comment:
   +1 to this approach. Dropping the `python`/`realpath` branch removes the 
Python dependency completely, makes Linux and macOS take the exact same code 
path, and avoids interpolating `${source_dir}` inside a single-quoted Python 
string.
   
   I verified locally on macOS that `cd "${source_dir}" && find . ... | awk -F/ 
'{print $2}' | sort -u` produces the exact same top-level entries as the 
current `os.path.relpath` command (including the root `pom.xml`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to