pierre-warnier commented on PR #908: URL: https://github.com/apache/arrow-rs-object-store/pull/908#issuecomment-6973041581
Thanks @bretzay, this is a much better review than I expected for a dependency swap. You're right, the test comment overstated parity. I reproduced your comparison independently against `humantime` 2.4.0 (my own input set: every unit spelling with 28 number forms, 3,000 random multi-term sequences in any order with fractions, plus edge cases, 5,270 inputs in all). Of the 4,151 inputs humantime accepts, the previous version of this PR refused 2,613; with your patch, all but two return humantime's value to the nanosecond, and those two are `1 0s` and `1 .5s`, as you said. The only extra accepts are sub-second fractions (`0.001d`) and `"0 "`. 5,000 formatted durations all parse back to themselves. I applied your patch as is in 67985f7 with you as co-author, and updated the description. With it: `cargo test --lib --features cloud-base config::` passes (and the full `--lib --features aws,azure,gcp,http`, 274 passed), `cargo fmt --all -- --check` is clean, `cargo clippy -- -D warnings` is clean with the three feature sets you listed, and `cargo +1.85.0 check --all-targets --all-features` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
