Phoenix500526 opened a new pull request, #12314:
URL: https://github.com/apache/arrow-rs/pull/12314

   # Which issue does this PR close?
   
   - Part of #12295: covers Hadoop LZ4 and Avro varint attribution. The Serde 
example remains open.
   
   # Rationale for this change
   
   The Hadoop LZ4 and Avro varint implementations include adapted third-party 
code whose copyright notices and license terms were not fully reflected in the 
distribution's `NOTICE.txt` and `LICENSE.txt`.
   
   # What changes are included in this PR?
   
   - Add parquet2's Apache-2.0 attribution to `NOTICE.txt`, following the 
compact-thrift treatment in #9704, and replace the broken Polars documentation 
link with a working parquet2 source link.
   - Add prost's Apache-2.0 attribution to `NOTICE.txt`. Add the Protocol 
Buffers C++ and protobuf-go copyright notices and their shared BSD 3-Clause 
terms to `LICENSE.txt`, following [Arrow C++'s treatment of adapted protobuf 
code](https://github.com/apache/arrow/blob/main/LICENSE.txt#L822).
   - Clarify the fast and slow varint decoders' source comments and preserve 
historical reference links.
   
   Source evidence:
   
   - #3013 introduced the LZ4 decoder with parquet2 and Arrow C++ references. 
The [parquet2 license at the function's 
introduction](https://github.com/jorgecarleitao/parquet2/blob/4319b0593dd8240db66cd4f7a9db416ed3ea4bfe/LICENSE)
 supplies the copyright notice retained here.
   - #6820 introduced the relevant Avro varint helpers. The [prost 
decoder](https://github.com/tokio-rs/prost/blob/5ae30c5fd2725132c4daa0ef9f6d2f14f1308bd5/prost/src/encoding/varint.rs)
 references both protobuf implementations; its [README license 
section](https://github.com/tokio-rs/prost/blob/5ae30c5fd2725132c4daa0ef9f6d2f14f1308bd5/README.md#license)
 supplies the prost attribution.
   - The [Protocol Buffers C++ source 
header](https://github.com/protocolbuffers/protobuf/blob/5532abc15b97f3489183b266b41844306052a3fa/src/google/protobuf/io/coded_stream.cc#L1-L29)
 and [protobuf-go v1.27.1 
license](https://github.com/protocolbuffers/protobuf-go/blob/v1.27.1/LICENSE) 
contain the same BSD terms, so the text is included once with both copyright 
notices.
   
   # Are these changes tested?
   
   Formatting, spelling, and whitespace checks passed. The upstream BSD terms 
were compared with the added text, ignoring comment prefixes and whitespace. 
Both crate package lists include `LICENSE.txt` and `NOTICE.txt`, whose symlinks 
resolve to the updated root files.
   
   No runtime tests were added or run: the Rust changes are comments only, and 
the executable code is unchanged.
   
   # Are there any significant user-facing changes?
   
   Distributions include the additional third-party notices. There are no 
runtime or public API changes.
   
   # AI usage disclosure
   
   AI assisted with source-history and license checks, the attribution and 
comment updates, and this PR description.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to