rok commented on code in PR #55264:
URL: https://github.com/apache/arrow/pull/55264#discussion_r4616424952


##########
.pre-commit-config.yaml:
##########
@@ -145,6 +145,70 @@ repos:
           (
           ?^python/pyarrow/vendored/|
           )
+  # Linting, formatting and type checking of the type stubs. The type checkers
+  # don't run on commit, only on request (the Lint CI job runs them too):
+  #   pre-commit run --hook-stage manual python-stubs --all-files
+  # The type checkers run with uvx, in the environment of
+  # python/requirements-stubs.txt. They don't need PyArrow installed: the
+  # modules that aren't annotated yet, e.g. pyarrow.compute, are treated as Any
+  # (see python/pyproject.toml).
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.17.2

Review Comment:
   Given pace of typechecker development this might be a good idea. Added 
https://github.com/apache/arrow/pull/55264/changes/34f5978ced9a2b1a0d804ad10b67ac708cd2eaa0,
 but we might need to discuss this in a wider setting? @jorisvandenbossche 
@AlenkaF @tadeja what do you think?



##########
python/requirements-stubs.txt:
##########
@@ -0,0 +1,20 @@
+# Type checkers and the type stubs of PyArrow's dependencies, pinned so that

Review Comment:
   Using `uv.lock` might be a good idea, but we're not using uv widely enough 
yet I think. Added another dependabot 
https://github.com/apache/arrow/pull/55264/changes/0733c1de69bc7e1fd79e33fc5459ce66a20db529
 to track versions.
    @jorisvandenbossche @AlenkaF @tadeja what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to