Phoenix500526 commented on issue #12295:
URL: https://github.com/apache/arrow-rs/issues/12295#issuecomment-6983591023

   > 
https://github.com/apache/arrow-rs/blob/4f1ed42f7a1fb76d090ec1351cfdb6e904f59f0b/parquet/src/compression.rs#L719-L723
   > 
   > * [Hadoop LZ4 Support for LZ4 Codec 
#3013](https://github.com/apache/arrow-rs/pull/3013)
   > 
   > 
https://github.com/apache/arrow-rs/blob/4f1ed42f7a1fb76d090ec1351cfdb6e904f59f0b/arrow-avro/src/reader/vlq.rs#L62-L67
   > 
   > * [Support Parsing Avro File Headers 
#4888](https://github.com/apache/arrow-rs/pull/4888)
   
   For this two issues, I've opened a PR #12314 to address them. 
   
   
   > The relevant sections are:
   > 
   > 
https://github.com/apache/arrow-rs/blob/4f1ed42f7a1fb76d090ec1351cfdb6e904f59f0b/arrow-json/src/reader/serializer.rs#L32-L35
   > 
   > * [Support Rust structures --> `RecordBatch` by adding `Serde` support to 
`RawDecoder` (#3949) #3979](https://github.com/apache/arrow-rs/pull/3979)
   
   But for this issue, I think “Heavily based on” overstates the similarity 
after comparing the original implementation with the Serde example. Apart from 
one identical comment about JSON maps, the matching signatures follow the 
Serializer trait, and the delegations are natural ways to implement it. The 
underlying implementations differ, so these similarities alone do not establish 
substantive copying. 
   
   The Serde documentation repository uses [CC-BY-SA 
4.0](https://github.com/serde-rs/serde-rs.github.io/blob/0de9c8972804143a2295c8cfdc6da341d03f4338/LICENSE-CC-BY-SA).
 [ASF policy](https://apache.org/legal/resolved#cc-sa) permits unmodified media 
under this license, explicitly excludes source code from that exception. And 
for other uses, it states: “For any other type of CC-SA licensed work, contact 
the Legal PMC.”
   
   I think maybe we should remove the “Heavily based on” comment. What do you 
say? @Jefffrey @alamb @Xuanwo 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to