hcrosse commented on code in PR #1606:
URL: https://github.com/apache/arrow-go/pull/1606#discussion_r4618324330
##########
parquet/file/column_reader.go:
##########
@@ -644,8 +644,12 @@ func (c *columnChunkReader) determineNumToRead(batchLen
int64, defLvls, repLvls
// finds the page that contains the desired row index, and the Column Chunk
// reader will discard values until it reaches the desired row index according
// to the definition and repetition levels.
+//
+// If the seek fails, the reader stays stopped and returns the error until a
+// later SeekToRow succeeds.
func (c *columnChunkReader) SeekToRow(rowIdx int64) error {
if err := c.pager().SeekToPageWithRow(rowIdx); err != nil {
+ c.err = err
Review Comment:
Thanks, makes sense. An out of range `SeekToRow` now returns the error and
leaves the reader where it was. I added tests for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]