jorisvandenbossche commented on PR #55484: URL: https://github.com/apache/arrow/pull/55484#issuecomment-6986049697
On the community meeting, it was mentioned that the top description is actually no longer up to date: > Boring Cyborg checks ... On PRs to `main` it fills the `GitHub Issue:` line with a native closing reference. For a partial fix, change that line to `Refs` and the issue number; the bot preserves it. Committers should check the issue line before merging, particularly for existing PRs. GitHub owns closure and records the resolving PR on the issue. However, personally I think it is simpler to just rely on github's auto-closing of issues based on a "closes #.." (or equivalent). IMO it is simpler (for the maintainer, because that is in general how github works, and you don't have to know all details of our custom workflows) and avoids having additional custom workflow logic (it also allows the maintainer for whatever reason to not close the issue by merging the PR, or if we in the future want to use this practice more) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
