Jefffrey commented on code in PR #12293:
URL: https://github.com/apache/arrow-rs/pull/12293#discussion_r4624743611


##########
arrow-array/src/builder/fixed_size_binary_builder.rs:
##########
@@ -210,6 +210,16 @@ mod tests {
         assert_eq!(b"world", array.value(5));
     }
 
+    #[test]
+    #[cfg(target_pointer_width = "64")]
+    #[ignore = "allocates >4GB to test 32-bit length truncation"]
+    fn test_fixed_size_binary_builder_rejects_wrapped_length() {
+        let mut b = FixedSizeBinaryBuilder::new(1);
+        let big = vec![0u8; (1usize << 32) + 1];

Review Comment:
   i think we're better off removing this test; the fix is simple enough, and 
any mechanism to work around this would probably be overly complex



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to