geoffreyclaude commented on code in PR #11771:
URL: https://github.com/apache/arrow-rs/pull/11771#discussion_r4627542800


##########
arrow-row/src/lib.rs:
##########
@@ -897,6 +916,9 @@ impl Codec {
                     field_to_type_ids: field_to_type_ids.clone(),
                     type_ids,
                     offsets,
+                    nulls: union_array

Review Comment:
   Added Union cases to `row_format`. I’m accepting the extra cost for the 
correctness fix here. Follow-up #12235 has the optimization and the timing and 
allocation results.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to