alamb commented on code in PR #11482:
URL: https://github.com/apache/arrow-rs/pull/11482#discussion_r4629061384


##########
.github/workflows/arrow.yml:
##########
@@ -37,6 +37,8 @@ jobs:
           cargo test -p arrow-array --all-features
           # Disable feature `force_validate`
           cargo test -p arrow-array --features=ffi
+          # `--all-features` resolves named timezones with jiff, so test 
chrono-tz on its own

Review Comment:
   i think the detail about named timezones is too specif here and below -- the 
point is to test with the jiff feature (which over time will have more than 
just named timezones)



##########
arrow-array/src/lib.rs:
##########
@@ -259,6 +259,10 @@ pub mod nonblocking;
 pub mod run_iterator;
 pub mod temporal_conversions;
 pub mod timezone;
+// `jiff` takes precedence over `chrono-tz` when both are enabled, leaving 
chrono-tz compiled but
+// unreferenced. Keep `-D unused_crate_dependencies` satisfied for 
`--all-features` builds.

Review Comment:
   what is the purpose of saying " Keep `-D unused_crate_dependencies` 
satisfied for `--all-features` builds." here?



##########
arrow/README.md:
##########
@@ -49,6 +49,7 @@ The `arrow` crate provides the following features which may 
be enabled in your `
 - `prettyprint` - support for formatting record batches as textual columns
   implementations of some 
[compute](https://github.com/apache/arrow-rs/tree/main/arrow/src/compute/kernels)
 - `chrono-tz` - support of parsing timezone using 
[chrono-tz](https://docs.rs/chrono-tz/0.6.0/chrono_tz/)
+- `jiff` - support of parsing timezone using 
[jiff](https://docs.rs/jiff/latest/jiff/), which keeps applying a zone's 
daylight saving rules past the last precomputed transition. Takes precedence 
over `chrono-tz`, so enabling it for any crate in a build applies to the whole 
build

Review Comment:
   Again I think here the `jiff` feature flag is going to apply to much more 
than timezone parsing, so continually referencing timezones is a bit of tech 
debt that we will have to clean up



##########
arrow-array/src/timezone.rs:
##########
@@ -532,6 +1118,23 @@ mod tests {
         assert!(err.contains("Invalid timezone"), "{}", err);
     }
 
+    #[test]
+    fn test_tzdb_version() {

Review Comment:
   I think this test could probably be dropped -- as the API is just a pass 
through



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to