MassivePizza commented on PR #12318: URL: https://github.com/apache/arrow-rs/pull/12318#issuecomment-7015058885
Yep, `make_array(array.to_data())` is not ideal. Tested slicing and I'm a little disappointed with it on `i64->temporal`, but slicing improves like 5 other casts so I'd like to keep both. | bench | main | PR | change | |---|---:|---:|---:| | cast i64 to timestamp_ns 512 | 129.2 ns | 63.7 ns | −51% | | cast i64 to duration_ns 512 | 119.2 ns | 65.9 ns | −45% | Also found a possible improvement for `NullBuffer::slice` while checking this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
