edgarrmondragon commented on code in PR #1026:
URL: https://github.com/apache/arrow-nanoarrow/pull/1026#discussion_r4633324737
##########
python/src/nanoarrow/_array.pyi:
##########
@@ -87,6 +87,7 @@ class CArrayBuilder:
"""
def append_bytes(self, *args, **kwargs): ...
def append_strings(self, *args, **kwargs): ...
+ def ensure_buffers(self, n_buffers) -> CArrayBuilder: ...
Review Comment:
Aren't this and `set_map_keys_sorted` below hand edits? i.e. wouldn't this
change to `def ensure_buffers(self, *args, **kwargs): ...` when the stubs are
regenerated with the script?
That is, these two method don't follow the new guideline in the readme:
> Review the generated diff before committing it.
##########
python/src/nanoarrow/_array.pyi:
##########
@@ -87,6 +87,7 @@ class CArrayBuilder:
"""
def append_bytes(self, *args, **kwargs): ...
def append_strings(self, *args, **kwargs): ...
+ def ensure_buffers(self, n_buffers) -> CArrayBuilder: ...
Review Comment:
Aren't this and `set_map_keys_sorted` below hand edits? i.e. wouldn't this
change to `def ensure_buffers(self, *args, **kwargs): ...` when the stubs are
regenerated with the script?
That is, these two methods don't follow the new guideline in the readme:
> Review the generated diff before committing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]