edgarrmondragon commented on code in PR #1027:
URL: https://github.com/apache/arrow-nanoarrow/pull/1027#discussion_r4634733780


##########
python/src/nanoarrow/c_array.py:
##########
@@ -558,6 +567,24 @@ def _append_using_array(self, obj: Iterable) -> None:
         self._c_builder.set_null_count(0)
         self._c_builder.set_offset(0)
 
+    def _convert_dates(self, obj: Iterable) -> Iterable:
+        from datetime import date, datetime
+
+        epoch_ordinal = date(1970, 1, 1).toordinal()

Review Comment:
   Perhaps hardcode the epoch's Gregorian ordinal?
   
   
   ```suggestion
           epoch_ordinal = 719163  # date(1970, 1, 1).toordinal()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to