comphead commented on code in PR #12058:
URL: https://github.com/apache/arrow-rs/pull/12058#discussion_r4634462792


##########
arrow/benches/arithmetic_kernels.rs:
##########
@@ -60,5 +66,105 @@ fn add_benchmark(c: &mut Criterion) {
     }
 }
 
-criterion_group!(benches, add_benchmark);
+/// Like `create_primitive_array_range`, but with its own `seed`, so that two
+/// arrays hold different values and nulls.
+fn seeded_array<T>(

Review Comment:
   `seeded_array` is `create_primitive_array_range` with a seed, and 
https://github.com/apache/arrow-rs/pull/12062 adds the same copy to this file. 
Could it move to `arrow/src/util/bench_util.rs` as 
`create_primitive_array_range_with_seed`, next to 
`create_primitive_array_with_seed`? Both PRs could then use one copy, and this 
file would stop conflicting between them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to