alamb commented on code in PR #12268:
URL: https://github.com/apache/arrow-rs/pull/12268#discussion_r4636076175
##########
arrow-ipc/src/writer.rs:
##########
@@ -1274,21 +1274,52 @@ fn ensure_supported_ipc_data_type(
}
}
-fn append_variadic_buffer_counts(counts: &mut Vec<i64>, array: &ArrayData) {
+fn append_variadic_buffer_counts(
+ counts: &mut Vec<i64>,
+ array: &ArrayData,
+) -> Result<(), ArrowError> {
match array.data_type() {
DataType::BinaryView | DataType::Utf8View => {
// The spec documents the counts only includes the variadic
buffers, not the view/null buffers.
//
https://arrow.apache.org/docs/format/Columnar.html#variadic-buffers
counts.push(array.buffers().len() as i64 - 1);
+ Ok(())
}
DataType::Dictionary(_, _) => {
// Do nothing
// Dictionary values are handled in special dictionary messages
+ Ok(())
+ }
+ DataType::RunEndEncoded(_, _) => {
+ // The writer writes the children of the unsliced run array, so
Review Comment:
it seems like maybe we should update the writer write the sliced values
rather than the unsliced values 🤔 what is the value of writing the unsliced
buffers 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]