zanmato1984 commented on code in PR #51325:
URL: https://github.com/apache/arrow/pull/51325#discussion_r4640359701
##########
cpp/src/arrow/compare.h:
##########
@@ -108,6 +108,19 @@ class EqualOptions {
return res;
}
+ /// Whether to compare floating-point values by their physical
representation.
+ bool physical_repr_equal() const { return physical_repr_equal_; }
+
+ /// Return a copy of this EqualOptions object with the "physical_repr_equal"
+ /// property set to the specified value.
+ /// If both "physical_repr_equal" and "nans_equal" are enabled, two values
+ /// are considered equal if either condition is satisfied.
+ EqualOptions physical_repr_equal(bool v) const {
Review Comment:
Yes, a separate issue makes sense. Thanks for checking the other options and
pointing out the same-pointer case. I’m happy to leave the sparse tensor
changes out of this PR. Could you link the follow-up issue here once it’s open?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]