HuaHuaY commented on code in PR #54691:
URL: https://github.com/apache/arrow/pull/54691#discussion_r4641869368
##########
python/pyarrow/_csv.pyx:
##########
@@ -588,12 +605,20 @@ cdef class ParseOptions(_Weakrefable):
def __getstate__(self):
return (self.delimiter, self.quote_char, self.double_quote,
self.escape_char, self.newlines_in_values,
- self.ignore_empty_lines, self.invalid_row_handler)
+ self.ignore_empty_lines, self.invalid_row_handler,
+ self.pad_short_rows)
def __setstate__(self, state):
- (self.delimiter, self.quote_char, self.double_quote,
- self.escape_char, self.newlines_in_values,
- self.ignore_empty_lines, self.invalid_row_handler) = state
+ if len(state) == 7:
Review Comment:
I’m not familiar with PyArrow. When `invalid_row_handler` was added,
`__setstate__` went from six fields to seven without handling the old state
https://github.com/apache/arrow/commit/11040609fc4f6c1e7a2cdbfc8279598a7afccb68.
Do we need to consider backward compatibility? @pitrou Please help to take a
look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]