tadeja commented on code in PR #55299:
URL: https://github.com/apache/arrow/pull/55299#discussion_r4643218602
##########
r/configure:
##########
@@ -365,6 +365,14 @@ add_feature_flags () {
fi
if arrow_built_with ARROW_AZURE; then
PKG_CFLAGS_FEATURES="$PKG_CFLAGS_FEATURES -DARROW_R_WITH_AZURE"
+ PKG_CONFIG_NAMES_FEATURES="$PKG_CONFIG_NAMES_FEATURES arrow-azure"
+ if [ -n "$(find "$LIB_DIR" -name
'libarrow_azure_bundled_dependencies.*')" ]; then
+ PKG_LIBS_FEATURES_WITHOUT_PC="-larrow_azure
-larrow_azure_bundled_dependencies $PKG_LIBS_FEATURES_WITHOUT_PC"
+ else
+ PKG_LIBS_FEATURES_WITHOUT_PC="-larrow_azure
$PKG_LIBS_FEATURES_WITHOUT_PC"
Review Comment:
Optional guard, this would keep R configure working with pre-split libarrow
```suggestion
# Pre-split builds provide Azure in libarrow and have no
arrow-azure.pc.
if [ -f "$LIB_DIR/pkgconfig/arrow-azure.pc" ]; then
PKG_CONFIG_NAMES_FEATURES="$PKG_CONFIG_NAMES_FEATURES arrow-azure"
if [ -n "$(find "$LIB_DIR" -name
'libarrow_azure_bundled_dependencies.*')" ]; then
PKG_LIBS_FEATURES_WITHOUT_PC="-larrow_azure
-larrow_azure_bundled_dependencies $PKG_LIBS_FEATURES_WITHOUT_PC"
else
PKG_LIBS_FEATURES_WITHOUT_PC="-larrow_azure
$PKG_LIBS_FEATURES_WITHOUT_PC"
fi
```
As [crossbow job `test-r-extra-packages` on
PR](https://github.com/ursacomputing/crossbow/actions/runs/44096339394/job/134084327390#step:6:35)
currently fails:
```
*** Successfully retrieved libarrow (linux-x86_64)
Package arrow-azure was not found in the pkg-config search path.
Perhaps you should add the directory containing `arrow-azure.pc'
to the PKG_CONFIG_PATH environment variable
...
PKG_LIBS= -lxml2
ERROR: configuration failed for package ‘arrow’
* removing ‘/home/runner/work/_temp/Library/arrow’
```
This was similar with GCS before;
#54905 merged on 27 Oct, then `test-r-extra-packages` was failing from 28
Oct [log1](
https://github.com/ursacomputing/crossbow/actions/runs/40639172080/job/122653026688#step:6:35)
```
*** Latest available nightly for 26.0.0.9000: 26.0.0.100000032
*** Found libcurl and OpenSSL >= 3.0
*** Successfully retrieved libarrow (linux-x86_64)
Package arrow-gcs was not found in the pkg-config search path.
Perhaps you should add the directory containing `arrow-gcs.pc'
to the PKG_CONFIG_PATH environment variable
Package 'arrow-gcs' not found
```
up to including 5 Nov failing [log2 , downloaded 26.0.0.100000032, missing
`arrow-gcs.pc`](https://github.com/ursacomputing/crossbow/actions/runs/41982144225/job/127094457763)
successful 6 Nov [log3 - downloaded 26.0.1.100000097, pkg-config returned
`-DARROW_GCS_STATIC` and
`-larrow_gcs`](https://github.com/ursacomputing/crossbow/actions/runs/42175722391/job/127753597984)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]