alamb commented on PR #12356: URL: https://github.com/apache/arrow-rs/pull/12356#issuecomment-7042167825
To be honest I don't think we need a benchmark for this change -- we can see by inspection that the code does less work / fewer allocations I worry that making benchmarks like this will lead us to be chasing down allocation shadow effects rather than real issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
