hcrosse opened a new pull request, #1645:
URL: https://github.com/apache/arrow-go/pull/1645

   ### Rationale for this change
   
   arrow-go writes encrypted row group and column ordinals above 32767 that 
Arrow C++ refuses to read, and arrow-go's own reader also rejects those columns.
   
   ### What changes are included in this PR?
   
   `AppendRowGroupChecked` and `AppendBufferedRowGroupChecked` refuse the 
32769th encrypted row group and leave the writer usable, so `Close` still 
writes a valid file with the first 32768 row groups as Arrow C++ does. 
`pqarrow`'s `FileWriter.WriteTable` closes on error, so it now leaves that file 
and returns the error.
   
   `NewParquetWriterWithError` rejects encrypted columns at index 32768 or 
above before writing. Unencrypted files and columns are not limited. The reader 
is unchanged.
   
   ### Are these changes tested?
   
   Yes. I added tests for rejecting ordinals above the limit, closing after 
rejection, the 32768 boundary and unencrypted controls.
   
   ### Are there any user-facing changes?
   
   Yes. Encrypted row group and column ordinals above 32767 are rejected. There 
is no API change.
   
   Closes #1644.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to