zeroshade commented on PR #1630: URL: https://github.com/apache/arrow-go/pull/1630#issuecomment-7045115808
Thanks @amoeba, good suggestion. Done in the second commit: `Reader` and `FileReader` now embed an `ipcDecoder` with the schema, memo, allocator, endianness flag and zstd decoders, and `readDictionary`, `newRecordBatch` and `loadRecordBatch` are methods on it. The call sites are down to `r.readDictionary(msg.meta, msg.body)`, and the zstd decoders no longer appear in any signature outside `getDecompressor`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
