bhaskargurram-ai commented on PR #11333: URL: https://github.com/apache/arrow-rs/pull/11333#issuecomment-7053486941
Thanks for the detailed review, and no worries about the wait. I applied all of the suggestions in a5caeed: the encodings now go through `WriterProperties` and are checked per column after the properties are built (still before the output file is created), `--column-encoding` is case sensitive like `--encoding` and rejects the dictionary and bit-packed encodings at parse time, and the tests are down to the writer check and one end-to-end rewrite. I also merged main, since the earlier CI runs expired before they were approved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
