mbutrovich commented on code in PR #12347:
URL: https://github.com/apache/arrow-rs/pull/12347#discussion_r4653546046


##########
arrow-buffer/src/buffer/boolean.rs:
##########
@@ -620,6 +622,23 @@ impl BooleanBuffer {
         BitSliceIterator::new(self.values(), self.bit_offset, self.bit_len)
     }
 
+    /// Returns a [`SetBitCounter`] that counts the set bits before positions 
in
+    /// this [`BooleanBuffer`]
+    ///
+    /// ```
+    /// # use arrow_buffer::BooleanBuffer;
+    /// // Validity of the elements of a list with rows of 3, 0, and 2 elements
+    /// let valid = BooleanBuffer::from(&[true, false, true, true, true][..]);

Review Comment:
   `BooleanBuffer` implements `From<&[bool]>` and `From<Vec<bool>>` but not 
`From<[bool; N]>`, so the array literal needed `[..]` to become a slice. The 
examples use `vec![...]` now, like the tests in `boolean.rs`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to