jhorstmann commented on PR #12370: URL: https://github.com/apache/arrow-rs/pull/12370#issuecomment-7067024638
When I prototyped the thrift macros, one goal was to be able to easily diff that part of the code against the upstream thrift definitions. While this is already more complicated here in arrow-rs due to the structuring and amount of custom parsing, replacing the literals with named constants makes it even more difficult. Wouldn't another option be to create these modules with named constants from the same thrift macros? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
