Dandandan commented on a change in pull request #503:
URL: https://github.com/apache/arrow-datafusion/pull/503#discussion_r645684310
##########
File path: datafusion/src/logical_plan/plan.rs
##########
@@ -50,6 +52,28 @@ pub enum JoinType {
Anti,
}
+impl FromStr for JoinType {
Review comment:
IMO it would be better if the python api also used enum (or typed string
union) too, at least for autocompletion and optional type checking, but keeping
it for now as strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
