boaz-codota commented on pull request #383: URL: https://github.com/apache/arrow-rs/pull/383#issuecomment-855236871
Fix the tests, could you review? @Dandandan @alamb ? Also, @alamb I noticed that in https://github.com/influxdata/influxdb_iox/blob/main/arrow_util/src/bitset.rs#L87 is differ from what is done here: ```rust // influx_iox data[byte_idx] |= 1 << (i & 7) ``` vs ```rust // arrow-rs const BIT_MASK: [u8; 8] = [1, 2, 4, 8, 16, 32, 64, 128]; // ... data[i >> 3] |= BIT_MASK[i & 7]; ``` which I haven't tested but might have performance implications (?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
