nevi-me commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r645996852
##########
File path: datafusion/src/physical_optimizer/pruning.rs
##########
@@ -586,8 +587,45 @@ fn build_predicate_expression(
.min_column_expr()?
.lt_eq(expr_builder.scalar_expr().clone())
}
+ Operator::Like => {
+ match &**right {
+ // If the literal is a 'starts_with'
+ Expr::Literal(ScalarValue::Utf8(Some(string)))
+ if !string.starts_with('%') =>
+ {
+ let scalar_expr =
+
Expr::Literal(ScalarValue::Utf8(Some(string.replace('%', ""))));
+ // Behaves like Eq
+ let min_column_expr = expr_builder.min_column_expr()?;
+ let max_column_expr = expr_builder.max_column_expr()?;
+ min_column_expr
+ .lt_eq(scalar_expr.clone())
+ .and(scalar_expr.lt_eq(max_column_expr))
+ }
+ _ => unhandled,
+ }
+ }
+ Operator::NotLike => {
+ match &**right {
+ // If the literal is a 'starts_with'
+ Expr::Literal(ScalarValue::Utf8(Some(string)))
+ if !string.starts_with('%') =>
Review comment:
I only focused on expressions that don't start with `%`, under the
assumption that they would be a `starts_with`. I don't think we can support
anything other than a `starts_with` because we translate the queries to `min
LtEq value && value LtEq max`.
Or how would `LIKE '100\% %'` be evaluated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
