tustvold commented on a change in pull request #521:
URL: https://github.com/apache/arrow-datafusion/pull/521#discussion_r646611109
##########
File path: datafusion/src/physical_plan/repartition.rs
##########
@@ -308,6 +310,45 @@ impl RepartitionExec {
send_time_nanos: SQLMetric::time_nanos(),
})
}
+
+ /// Waits for `input_task` which is consuming one of the inputs to
Review comment:
I wonder if it might be slightly clearer to push the body of the main
task into a fallible function, and to then handle propagating any error it
returns within the spawned task? i.e. rather than propagating the error through
the JoinHandle, make the task that is spawned onto tokio infallible and handle
its errors internally??
Edit: I guess the advantage with this approach would be that you could
propagate panics as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
