pitrou commented on a change in pull request #10255:
URL: https://github.com/apache/arrow/pull/10255#discussion_r646615349
##########
File path: cpp/src/arrow/csv/chunker.cc
##########
@@ -235,10 +235,10 @@ class LexingBoundaryFinder : public BoundaryFinder {
return Status::OK();
}
- Status FindNth(util::string_view partial, util::string_view block, uint64_t
count,
- int64_t* out_pos, uint64_t* num_found) override {
+ Status FindNth(util::string_view partial, util::string_view block, int64_t
count,
Review comment:
That's the convention we use across the Arrow codebase (for example all
lengths and offsets are signed, even though they are positive). Given that C++
(and especially some compilers) can be annoying with implicit casts or mixed
signed-unsigned operations, it's better not to introduce unsigned variables
gratuitously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
