jychen7 commented on a change in pull request #519:
URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646693623
##########
File path: datafusion/src/sql/utils.rs
##########
@@ -390,6 +391,29 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) ->
HashMap<String, Expr> {
.collect::<HashMap<String, Expr>>()
}
+pub(crate) fn resolve_positions_to_exprs(
+ expr: &Expr,
Review comment:
we probably keep reference, to be consistent with
https://github.com/apache/arrow-datafusion/blob/6bcd83b9209eb5af4a0c7283fc78a4dad5391f2b/datafusion/src/sql/utils.rs#L419-L422
will simplify `match` to have only one `Ok(expr.clone())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
