jorgecarleitao commented on a change in pull request #424:
URL: https://github.com/apache/arrow-rs/pull/424#discussion_r647104155
##########
File path: arrow/src/compute/kernels/partition.rs
##########
@@ -25,7 +25,7 @@ use std::cmp::Ordering;
/// Given a list of sort columns, find partition points that would partition
lexicographically
/// equal values across columns; Here LexicographicalComparator is used in
conjunction with binary
/// search so the columns *MUST* be pre-sorted already.
-pub fn lex_partition_points(columns: &[SortColumn]) -> Result<Vec<usize>> {
+pub fn lexicographical_partition_points(columns: &[SortColumn]) ->
Result<Vec<usize>> {
Review comment:
Maybe return `UIntArray64` instead of `Vec<usize>` to keep it consistent
with the rest of the kernels?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
