jorgecarleitao commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r647107983
##########
File path: datafusion/src/physical_optimizer/pruning.rs
##########
@@ -586,8 +587,47 @@ fn build_predicate_expression(
.min_column_expr()?
.lt_eq(expr_builder.scalar_expr().clone())
}
+ Operator::Like => {
+ match &**right {
+ // If the literal is a 'starts_with'
+ Expr::Literal(ScalarValue::Utf8(Some(string)))
+ if !string.starts_with('%') =>
+ {
+ // Split the string to get the first part before '%'
+ let split = string.split('%').next().unwrap().to_string();
Review comment:
won't this `unwrap` panic if the string does not contain any `%`? (if
"like" always requires that, maybe we should throw an error instead?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]