kou commented on a change in pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#discussion_r647134079
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -15,6 +15,36 @@
# specific language governing permissions and limitations
# under the License.
+function(extract_utf8proc_version)
+ if(utf8proc_INCLUDE_DIR)
+ file(READ "${utf8proc_INCLUDE_DIR}/utf8proc.h" UTF8PROC_H_CONTENT)
+
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MAJOR [0-9]+"
+ UTF8PROC_MAJOR_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MINOR [0-9]+"
+ UTF8PROC_MINOR_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_PATCH [0-9]+"
+ UTF8PROC_PATCH_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MAJOR_VERSION
+ "${UTF8PROC_MAJOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MINOR_VERSION
+ "${UTF8PROC_MINOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_PATCH_VERSION
+ "${UTF8PROC_PATCH_VERSION_DEFINITION}")
+
+ string(STRIP "${UTF8PROC_MAJOR_VERSION}" UTF8PROC_MAJOR_VERSION)
+ string(STRIP "${UTF8PROC_MINOR_VERSION}" UTF8PROC_MINOR_VERSION)
+ string(STRIP "${UTF8PROC_PATCH_VERSION}" UTF8PROC_PATCH_VERSION)
Review comment:
Can we simplify them?
```suggestion
string(REGEX MATCH "[0-9.]+" UTF8PROC_MAJOR_VERSION
"${UTF8PROC_MAJOR_VERSION_DEFINITION}")
string(REGEX MATCH "[0-9.]+" UTF8PROC_MINOR_VERSION
"${UTF8PROC_MINOR_VERSION_DEFINITION}")
string(REGEX MATCH "[0-9.]+" UTF8PROC_PATCH_VERSION
"${UTF8PROC_PATCH_VERSION_DEFINITION}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
