thisisnic commented on pull request #10436:
URL: https://github.com/apache/arrow/pull/10436#issuecomment-856705747
> This is looking good. A few more suggestions / comments now that I'm
seeing it written out. We should also probably wait for #10455 to merge before
we send this one so we can rebase + run the tests here and make sure that's all
sorted.
>
> Additionally, I noticed that a lot of this content is in the long running
+ starting/stoping PR #9748 as well. The only thing that isn't here that is in
#9748 is some reference to how `df %>% group_by("foo", "bar") %>%
write_dataset(...)` is the same thing as `write_dataset(df, partitioning =
c("foo", "bar"))` maybe we could add an example or two of that and then close
there other PR?
That PR is for `write_dataset`, whereas this one is for `open_dataset`
though. Maybe we could think more about what goes in which and get them more
in sync?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
