rok commented on a change in pull request #10490:
URL: https://github.com/apache/arrow/pull/10490#discussion_r648216614
##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##########
@@ -378,26 +378,25 @@ namespace internal {
namespace {
const FunctionDoc count_doc{"Count the number of null / non-null values",
- ("By default, non-null values are counted.\n"
+ ("By default, only non-null values are counted.\n"
"This can be changed through
ScalarAggregateOptions."),
{"array"},
"ScalarAggregateOptions"};
-const FunctionDoc sum_doc{"Sum values of a numeric array",
- ("Null values are ignored. Minimum count of non-NA\n"
- "values can be set and NAN is returned if too "
- "few are present.\n"
- "This can be changed through
ScalarAggregateOptions."),
- {"array"},
- "ScalarAggregateOptions"};
+const FunctionDoc sum_doc{
+ "Sum values of a numeric array",
Review comment:
it's a bit of a nit for consistency with `Compute the mean`.
##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##########
@@ -378,26 +378,25 @@ namespace internal {
namespace {
const FunctionDoc count_doc{"Count the number of null / non-null values",
- ("By default, non-null values are counted.\n"
+ ("By default, only non-null values are counted.\n"
"This can be changed through
ScalarAggregateOptions."),
{"array"},
"ScalarAggregateOptions"};
-const FunctionDoc sum_doc{"Sum values of a numeric array",
- ("Null values are ignored. Minimum count of non-NA\n"
- "values can be set and NAN is returned if too "
- "few are present.\n"
- "This can be changed through
ScalarAggregateOptions."),
- {"array"},
- "ScalarAggregateOptions"};
+const FunctionDoc sum_doc{
+ "Sum values of a numeric array",
Review comment:
```suggestion
"Compute the sum values of a numeric array",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
