edponce commented on pull request #10395: URL: https://github.com/apache/arrow/pull/10395#issuecomment-860021183
The [`Sign` kernels](https://github.com/edponce/arrow/blob/ARROW-12861-Compute-Add-sign-function-kernels/cpp/src/arrow/compute/kernels/scalar_arithmetic.cc#L402-L442) were created with a [fixed output type (Int8)](https://github.com/edponce/arrow/blob/ARROW-12861-Compute-Add-sign-function-kernels/cpp/src/arrow/compute/kernels/scalar_arithmetic.cc#L784-L790) using a new [kernel generator dispatcher](https://github.com/edponce/arrow/blob/ARROW-12861-Compute-Add-sign-function-kernels/cpp/src/arrow/compute/kernels/scalar_arithmetic.cc#L476-L505) but the [tests for `DispatchBest`](https://github.com/edponce/arrow/blob/ARROW-12861-Compute-Add-sign-function-kernels/cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc#L985-L998) fail. The output value from `DispatchBest` is the same as its input and the input/output values for `DispatchExact` are always `int8`. Could someone help with this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
