jorisvandenbossche commented on a change in pull request #10507:
URL: https://github.com/apache/arrow/pull/10507#discussion_r650738642
##########
File path: r/R/expression.R
##########
@@ -28,8 +28,17 @@
# stringr spellings of those
"str_length" = "utf8_length",
"str_to_lower" = "utf8_lower",
- "str_to_upper" = "utf8_upper"
+ "str_to_upper" = "utf8_upper",
# str_trim is defined in dplyr.R
+ "year" = "year",
+ "isoyear" = "iso_year",
+ "quarter" = "quarter",
+ "month" = "month",
+ "day" = "day",
+ "yday" = "day_of_year",
+ "isoweek" = "iso_week",
+ "minute" = "minute",
+ "second" = "second"
Review comment:
Agreed, I would also say that it's not because lubridate does not
support nanoseconds that *if* you actually have nanoseconds (which is possible
since arrow supports it) those should be discarded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
