pitrou commented on a change in pull request #10530:
URL: https://github.com/apache/arrow/pull/10530#discussion_r651644229



##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##########
@@ -536,6 +707,57 @@ TYPED_TEST(TestBinaryArithmeticSigned, MulOverflowRaises) {
   this->AssertBinop(Multiply, left, right, "[2, null, null]");
 }
 
+TYPED_TEST(TestBinaryArithmeticSigned, ShiftLeftLogicalOverflowRaises) {

Review comment:
       From a code organization POV, I think it would be more helpful to gather 
all shift tests close to each other.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to