bkietz commented on a change in pull request #10533:
URL: https://github.com/apache/arrow/pull/10533#discussion_r651910568
##########
File path: cpp/src/arrow/dataset/discovery.h
##########
@@ -237,16 +237,22 @@ class ARROW_DS_EXPORT FileSystemDatasetFactory : public
DatasetFactory {
std::shared_ptr<FileFormat> format,
FileSystemFactoryOptions
options);
+ /// \brief Build a FileSystemDatasetFactory from an explicit list of
+ /// filesystem information.
+ ///
+ /// \param[in] files passed to FileSystemDataset
+ /// \param[in] format passed to FileSystemDataset
+ /// \param[in] options see FileSystemFactoryOptions for more information.
+ static Result<std::shared_ptr<DatasetFactory>> Make(
+ std::shared_ptr<fs::FileSystem> filesystem, const
std::vector<fs::FileInfo>& files,
+ std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options);
+
Result<std::vector<std::shared_ptr<Schema>>> InspectSchemas(
InspectOptions options) override;
Result<std::shared_ptr<Dataset>> Finish(FinishOptions options) override;
protected:
- static Result<std::shared_ptr<DatasetFactory>> Make(
- std::shared_ptr<fs::FileSystem> filesystem, const
std::vector<fs::FileInfo>& files,
- std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options);
-
Review comment:
If it's convenient for you I think it's fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
