emkornfield commented on a change in pull request #10537:
URL: https://github.com/apache/arrow/pull/10537#discussion_r652315055
##########
File path: cpp/src/parquet/column_reader.cc
##########
@@ -861,8 +864,113 @@ class TypedColumnReaderImpl : public
TypedColumnReader<DType>,
Type::type type() const override { return this->descr_->physical_type(); }
const ColumnDescriptor* descr() const override { return this->descr_; }
+
+ ExposedEncodingType GetExposedEncoding() override { return
this->exposed_encoding_; };
+
+ int64_t ReadBatchWithDictionary(int64_t batch_size, int16_t* def_levels,
+ int16_t* rep_levels, int32_t* indices,
+ int64_t* indices_read, const T** dict,
+ int32_t* dict_len) override;
+
+ protected:
+ void SetExposedEncoding(ExposedEncodingType encoding) override {
+ this->exposed_encoding_ = encoding;
+ }
+
+ private:
+ /// \brief Read dictionary indices. Similar to ReadValues but decode data to
+ /// dictionary indices.
+ ///
+ /// Called only by ReadBatchWithDictionary().
+ ///
+ /// \note API EXPERIMENTAL
+ int64_t ReadDictionaryIndices(int64_t indices_to_read, int32_t* indices) {
+ auto decoder = dynamic_cast<DictDecoder<DType>*>(this->current_decoder_);
Review comment:
I see that you check below before calling this method. DCHECK for
documentation purposes can still make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
