emkornfield commented on a change in pull request #10537:
URL: https://github.com/apache/arrow/pull/10537#discussion_r652322630



##########
File path: cpp/src/parquet/file_reader.h
##########
@@ -56,6 +56,22 @@ class PARQUET_EXPORT RowGroupReader {
   // column. Ownership is shared with the RowGroupReader.
   std::shared_ptr<ColumnReader> Column(int i);
 
+  // Construct a ColumnReader, trying to enable exposed encoding.
+  //
+  // The encoding can only be exposed if the column chunk is encoded with the
+  // same encoding. For dictionary encoding, currently we only support column
+  // chunks that are fully dictionary encoded, i.e., all data pages in the
+  // column chunk are dictionary encoded. If a column chunk uses dictionary
+  // encoding but then falls back to plain encoding, the encoding cannot be

Review comment:
       ```suggestion
     // encoding but then falls back to plain encoding, the encoding will not be
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to