lidavidm commented on pull request #10547: URL: https://github.com/apache/arrow/pull/10547#issuecomment-864152392
Ah ok, thanks for confirming. Though, if there's another behavior we need for separators to match R's better we can extend the kernel. On Fri, Jun 18, 2021, at 12:26, Ian Cook wrote: > > ***@***.**** commented on this pull request. > > In r/R/dplyr-functions.R <https://github.com/apache/arrow/pull/10547#discussion_r654554241>: > > + # handle scalar literal NA consistent with the binary_join_element_wise + # kernel's handling of nulls in the data + if (null_handling == NullHandlingBehavior$REPLACE && is.na(arg)) { + arg <- null_replacement + } > > Aha, sorry, yes—I didn't look closely enough at the error messages. It's now only the case where the *separator* is a literal `NA` that's causing the function to emit `NA`, and that is the documented behavior: >> Null separators emit null. > So I think we're all good now. Thanks! > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <https://github.com/apache/arrow/pull/10547#discussion_r654554241>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQB3Y2D6DSFPYDU37BL43TTNXTZANCNFSM4625P4WQ>. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
