alamb commented on pull request #448:
URL: https://github.com/apache/arrow-rs/pull/448#issuecomment-864395352
I finally got a chance to re-run the tests
Using 2^14 = 16384
```
critcmp master bool-partition
group bool-partition master
----- -------------- ------
bool sort 2^14 1.00 1912.9±52.24µs ? ?/sec 1.09
2.1±0.16ms ? ?/sec
bool sort nulls 2^12 1.00 404.6±11.62µs ? ?/sec 1.06
426.9±25.21µs ? ?/sec
```
So looks like a nice change to me
Here is the test change in case anyone else wants to try:
```diff
diff --git a/arrow/benches/sort_kernel.rs b/arrow/benches/sort_kernel.rs
index f9f5f24c1..f517afede 100644
--- a/arrow/benches/sort_kernel.rs
+++ b/arrow/benches/sort_kernel.rs
@@ -80,9 +80,9 @@ fn add_benchmark(c: &mut Criterion) {
b.iter(|| bench_sort(&arr_a, &arr_b, None))
});
- let arr_a = create_bool_array(2u64.pow(12) as usize, false);
- let arr_b = create_bool_array(2u64.pow(12) as usize, false);
- c.bench_function("bool sort 2^12", |b| {
+ let arr_a = create_bool_array(2u64.pow(14) as usize, false);
+ let arr_b = create_bool_array(2u64.pow(14) as usize, false);
+ c.bench_function("bool sort 2^14", |b| {
b.iter(|| bench_sort(&arr_a, &arr_b, None))
});
```
Sorry for the delay @Jimexist -- it has been a busy few days for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
