edponce commented on a change in pull request #10395:
URL: https://github.com/apache/arrow/pull/10395#discussion_r656525276
##########
File path: cpp/src/arrow/compute/api_scalar.cc
##########
@@ -50,6 +50,11 @@ namespace compute {
SCALAR_ARITHMETIC_UNARY(AbsoluteValue, "abs", "abs_checked")
SCALAR_ARITHMETIC_UNARY(Negate, "negate", "negate_checked")
+Result<Datum> Sign(const Datum& arg, SignOptions options, ExecContext* ctx) {
+ auto func_name = options.with_signed_zero ? "sign_with_signed_zero" : "sign";
Review comment:
After careful thought, there is not a general need for having two
variants. The only case where I see that `sign_with_signed_zero` can be
relevant is if data stored is used for calculus-related operations (e.g.,
integral limits).
I will remove the `sign_with_signed_zero` variant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
