Jimexist commented on a change in pull request #490:
URL: https://github.com/apache/arrow-rs/pull/490#discussion_r656770581
##########
File path: arrow/src/record_batch.rs
##########
@@ -244,6 +244,21 @@ impl RecordBatch {
&self.columns[..]
}
+ /// Return a new RecordBatch where each column is sliced
+ /// according to `offset` and `length`
+ pub fn slice(&self, offset: usize, length: usize) -> Result<RecordBatch> {
Review comment:
can you remove the `Result` wrapping if nothing can fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
