returnString edited a comment on pull request #552:
URL: https://github.com/apache/arrow-datafusion/pull/552#issuecomment-866759239
Had to remind myself how all the catalog code works, but we _do_ support
registering tables into a schema via the trait. However, the trait method has a
default impl which fails:
```rust
fn register_table(
&self,
name: String,
table: Arc<dyn TableProvider>,
) -> Result<Option<Arc<dyn TableProvider>>> {
Err(DataFusionError::Execution(
"schema provider does not support registering
tables".to_owned(),
))
}
```
So if we wanted to do this for registering schemas into catalogs, we should
probably use the same style of fallible operation.
However, I only added this so as to continue supporting
ExecutionContext::register_table et al when doing the initial catalog
implementation, and it _does_ make the API more awkward for the infallible case
of working with memory schemas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
